Skip to content

Revert "deps: V8: override depot_tools version" - #66110

Open
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:revertdepottoolsoverride
Open

richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:revertdepottoolsoverride

Conversation

@richardlau

Copy link
Copy Markdown
Member

This reverts commit abff716.

No longer required as the override points to the same commit sha of depot_tools as deps/v8/DEPS.


This change only affects node-test-commit-v8-linux or make test-v8.

For context. we needed to roll to a newer version of depot_tools on older Node.js release lines for Python 3.12 compatibility in #62344. I noted at the time:

cc @nodejs/v8-update

This will need to be cherry-picked onto all release lines that we want to run the V8 CI on as it is necessary to run on Ubuntu 24.04 where the default Python 3 is 3.12.

We should also undo it with/after #61898 (or newer V8) as that will set a new enough version of depot_tools to be Python 3.12 compatible.

All of these point to depot_tools@284c5ccb591c3de4e9f71be4a4beb5d1916d5383 so the override is not needed on main and v26.x-staging:

main:

  • # Update depot_tools for compatibility with Python 3.12.
    "v8/third_party/depot_tools" : "https://chromium.googlesource.com/chromium/tools/depot_tools.git@284c5ccb591c3de4e9f71be4a4beb5d1916d5383",
  • node/deps/v8/DEPS

    Lines 228 to 229 in afbfccc

    'third_party/depot_tools':
    Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '284c5ccb591c3de4e9f71be4a4beb5d1916d5383',

v26.x-staging:

  • node/deps/v8/DEPS

    Lines 228 to 229 in da341e2

    'third_party/depot_tools':
    Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '284c5ccb591c3de4e9f71be4a4beb5d1916d5383',

Even worse, leaving the override would result in an older version of depot_tools than in deps/v8/DEPS from newer versions of V8 (e.g. #65161).

This reverts commit abff716.

No longer required as the override points to the same commit sha of
depot_tools as `deps/v8/DEPS`.

Signed-off-by: Richard Lau <richard.lau@ibm.com>
@richardlau richardlau added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 18, 2026
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants