Skip to content

tools: update tools/v8 for Python 3.13 #66109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardlau wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

tools: update tools/v8 for Python 3.13 #66109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tools/v8/fetch_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
Usage: fetch_deps.py <v8-path>
"""

# for py2/py3 compatibility
from __future__ import print_function

import os
import subprocess
import sys
Expand Down
8 changes: 3 additions & 5 deletions tools/v8/node_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# for py2/py3 compatibility
from __future__ import print_function

import os
import pipes
import shlex
import shutil
import stat
import subprocess
Expand All @@ -29,8 +27,8 @@ def _Get(v8_path):
print("Checking out depot_tools.")
# shell=True needed on Windows to resolve git.bat.
subprocess.check_call("git clone {} {}".format(
pipes.quote(DEPOT_TOOLS_URL),
pipes.quote(depot_tools)), shell=True)
shlex.quote(DEPOT_TOOLS_URL),
shlex.quote(depot_tools)), shell=True)
# Using check_output to hide warning messages.
subprocess.check_output(
[sys.executable, gclient_path, "metrics", "--opt-out"],
Expand Down
Loading