Skip to content

test: deflake test-run-watch-cwd-isolation-none-* #66107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 1 commit into from
+8 −21
Closed

test: deflake test-run-watch-cwd-isolation-none-* #66107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,17 @@
// parent process argv when spawning the watch child.
import * as common from '../common/index.mjs';
import assert from 'node:assert';
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { run } from 'node:test';
import tmpdir from '../common/tmpdir.js';
import fixtures from '../common/fixtures.js';
import { skipIfNoWatch } from '../common/watch.js';

skipIfNoWatch();
tmpdir.refresh();

writeFileSync(join(tmpdir.path, 'test.js'), `
const test = require('node:test');

test('test ran from cwd', () => {});
`);

const passed = [];
const controller = new AbortController();
const stream = run({
cwd: tmpdir.path,
// Avoid delayed file creation notifications triggering a watch restart.
cwd: fixtures.path('test-runner-watch'),
watch: true,
signal: controller.signal,
isolation: 'none',
Expand All @@ -38,4 +30,4 @@ stream.on('test:pass', common.mustCall((data) => passed.push(data.name), 1));
for await (const _ of stream);

// Validate the expected test ran by name:
assert.deepStrictEqual(passed, ['test ran from cwd']);
assert.deepStrictEqual(passed, ['test has ran']);
8 changes: 4 additions & 4 deletions test/test-runner/test-run-watch-cwd-isolation-none.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
// Test run({ watch: true, cwd, isolation: 'none' }) runs with different cwd while in watch mode and isolation none
import * as common from '../common/index.mjs';
import { run } from 'node:test';
import tmpdir from '../common/tmpdir.js';
import { refreshForTestRunnerWatch, skipIfNoWatch } from '../common/watch.js';
import fixtures from '../common/fixtures.js';
import { skipIfNoWatch } from '../common/watch.js';

skipIfNoWatch();
refreshForTestRunnerWatch();

const controller = new AbortController();
const stream = run({
cwd: tmpdir.path,
// Avoid delayed file creation notifications triggering a watch restart.
cwd: fixtures.path('test-runner-watch'),
watch: true,
signal: controller.signal,
isolation: 'none',
Expand Down
5 changes: 0 additions & 5 deletions test/test-runner/test-runner.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ prefix test-runner
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms

[$system==macos && $arch==x64]
# https://github.com/nodejs/node/issues/54534#issuecomment-5423551021
test-run-watch-cwd-isolation-none: PASS, FLAKY
test-run-watch-cwd-isolation-none-argv: PASS, FLAKY
Loading