Skip to content

test: avoid call to chmodSync in test-fs-cp-async-file-modes - #66104

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:test-fs-cp-async-file-modes
Open

aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:test-fs-cp-async-file-modes

Conversation

@aduh95

@aduh95 aduh95 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (9b82b6f) to head (0fa81a4).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66104   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         790      790           
  Lines      271642   271642           
  Branches    51846    51838    -8     
=======================================
+ Hits       245248   245254    +6     
+ Misses      16892    16889    -3     
+ Partials     9502     9499    -3     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 18, 2026
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Retr0astic added a commit to Retr0astic/nixos that referenced this pull request Sep 19, 2026
nixpkgs e554fab carries nodejs-slim 26.9.0, whose own test suite fails in
the build sandbox (test-fs-cp-async-file-modes hits EPERM on chmod). Hydra
fails the same build, so the package is not in any cache. iosevka in
modules/features/fonts.nix pulls nodejs in, so fontconfig, system-path and
the chapel toplevel all fail with it. bigrig is unaffected: no fonts.

Tracked as NixOS/nixpkgs#564449, fixed upstream in nodejs/node#66104.

This restores main's lock wholesale rather than hand-editing one node. The
five other bumps in this accept are dropped with it; tomorrow's run will
propose them again, and nixpkgs once the fix lands.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: nodejs-slim_26.x86_64-linux

5 participants