Skip to content

vfs: support renaming implicit ZIP directories - #65752

Open
trivikr wants to merge 3 commits into
nodejs:mainfrom
trivikr:vfs-zip-provider-rename
Open

vfs: support renaming implicit ZIP directories#65752
trivikr wants to merge 3 commits into
nodejs:mainfrom
trivikr:vfs-zip-provider-rename

Conversation

@trivikr

@trivikr trivikr commented Sep 3, 2026

Copy link
Copy Markdown
Member

Fixes: #65751

Treat archive entry prefixes as directories when renaming with ZipProvider. Move all descendant entries to the new prefix for both asynchronous and synchronous operations.


Assisted-by: codex:gpt-5.6-sol

Treat archive entry prefixes as directories when renaming with
ZipProvider. Move all descendant entries to the new prefix for both
asynchronous and synchronous operations.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 3, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.61039% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.96%. Comparing base (6e7818e) to head (1bb560a).

Files with missing lines Patch % Lines
lib/internal/vfs/providers/ziparchive.js 89.61% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65752   +/-   ##
=======================================
  Coverage   89.95%   89.96%           
=======================================
  Files         757      757           
  Lines      258053   258104   +51     
  Branches    48934    48936    +2     
=======================================
+ Hits       232144   232203   +59     
- Misses      16962    16970    +8     
+ Partials     8947     8931   -16     
Files with missing lines Coverage Δ
lib/internal/vfs/providers/ziparchive.js 96.83% <89.61%> (-1.11%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: ZipProvider.rename() fails with ENOENT for implicit directories

2 participants