vfs: fix rename over non-empty directory

[christianaurichzm]

MemoryProvider#renameSync() only rejected a destination whose type differed from the source (EISDIR/ENOTDIR). When both sides were directories it fell through to replacing the destination in its parent, so the destination directory and everything under it disappeared:

// node --experimental-vfs
const vfs = require('node:vfs').create();
vfs.mkdirSync('/src');
vfs.mkdirSync('/dst');
vfs.writeFileSync('/dst/keep.txt', 'keep');

vfs.renameSync('/src', '/dst');   // no error
vfs.existsSync('/dst/keep.txt');  // false

rename(2) accepts an existing directory as the destination only when it is empty, and fails with ENOTEMPTY otherwise. RealFSProvider delegates to fs.renameSync() and already behaves that way, so the two providers backing the same node:vfs API disagreed.

Two smaller fixes in the same function, both covered by the new tests:

• a file replaced by a rename now loses a link, so a hard link to it no longer reports an inflated nlink;
• a rename whose two names resolve to the same entry is a no-op; renaming one hard link onto another used to remove the source name while the file kept its old link count.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (705646f) to head (7789cf3).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65613      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.01%     
==========================================
  Files         754      754              
  Lines      256395   256408      +13     
  Branches    48499    48503       +4     
==========================================
+ Hits       230937   230942       +5     
  Misses      16569    16569              
- Partials     8889     8897       +8     

Files with missing lines	Coverage Δ
lib/internal/vfs/providers/memory.js	95.19% <100.00%> (+0.05%)	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[christianaurichzm]

@mcollina, since you just landed the VFS module-loader integration in 4d9cb71, would you mind taking a look at this MemoryProvider#renameSync() fix when convenient?

I rebased it onto the current main and re-ran test/parallel/test-vfs-rename.js successfully. The PR still has needs-ci, so a Jenkins CI run would also be appreciated once it looks ready.

Thanks!

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76856/

[christianaurichzm]

Looks like node-test-pull-request/76856 is still pending even though the resumed CI completed successfully. Possibly related to nodejs/build#4387.

[trivikr]

Landed in b53ddc0

[trivikr]

Landed manually as the CI failures were flaky tests, and there was no "Resume Build" button.