url: refactor URLPattern::{Exec,Test}#63667
Open
tniessen wants to merge 1 commit into
Open
Conversation
Refactor these `URLPattern` methods and extract common logic into a helper function, reducing code duplication. Signed-off-by: Tobias Nießen <tniessen@tnie.de>
tniessen
added
c++
nodejs-github-bot
added
needs-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63667 +/- ##
==========================================
+ Coverage 90.32% 90.33% +0.01%
==========================================
Files 732 732
Lines 236435 236428 -7
Branches 44527 44519 -8
==========================================
+ Hits 213563 213589 +26
+ Misses 14589 14541 -48
- Partials 8283 8298 +15
🚀 New features to boost your workflow:
|
anonrig
requested changes
May 31, 2026
| THROW_ERR_OPERATION_FAILED(env, "Failed to exec URLPattern"); | ||
| return; | ||
| R result{}; | ||
| if (((url_pattern->*func)(env, input, baseURL_opt).*to_r)(&result)) { |
Member
There was a problem hiding this comment.
I don't think this is readable at all.
| template <typename R, | ||
| typename M, | ||
| bool (M::*to_r)(R*) const, | ||
| M (URLPattern::*func)(Environment*, |
Member
There was a problem hiding this comment.
I don't think this is a good solution. Yes you're reducing code duplication but at what cost? reducing readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor these
URLPatternmethods and extract common logic into a helper function, reducing code duplication.