Skip to content

fix: normalize paths in Windows tests #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyanshisingh987456321 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

fix: normalize paths in Windows tests #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/generators/ast/generate.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { readFile } from 'node:fs/promises';
import { relative, sep } from 'node:path/posix';
import { relative, sep } from 'node:path';

import globParent from 'glob-parent';
import { globSync } from 'tinyglobby';
Expand Down Expand Up @@ -65,7 +65,7 @@ export async function processChunk(inputSlice, itemIndices) {
);

// The path is the relative path minus the extension
const relativePath = sep + withExt(relative(parent, path));
const relativePath = `/${withExt(relative(parent, path)).replaceAll(sep, '/')}`;
Comment on lines 4 to +68

@avivkeller avivkeller Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the exact same?

@ovflowd ovflowd Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like it is doing the opposite, converting any sep into / but that feels ... wrong? In Windows the \ sep should be used and not the / one 😅

@bmuenzenmeyer bmuenzenmeyer Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels backwards - sep is the right way to do this AFAIK


let tree;

Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/html/utils/copying.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function copyStaticAssets(config) {
} catch (err) {
if (err.code !== 'ENOENT') {
logger.error(
`[html-generator] Failed to copy asset from ${src} to ${dest}: ${err.message}`
`[html-generator] Failed to copy asset from ${src} to ${dest.replaceAll('\\', '/')}: ${err.message}`
);
}
}
Expand Down
3 changes: 1 addition & 2 deletions scripts/comparators/file-size.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ if (changed.length) {
base === 0 ? '' : ` (${sign}${((diff / base) * 100).toFixed(1)}%)`;
const diffFormatted = `${sign}${formatBytes(diff)}${percent}`;

return `| \`${file}\` | ${baseStats.has(file) ? formatBytes(base) : '—'} | ${headStats.has(file) ? formatBytes(head) : '—'} | ${diffFormatted} |`;
return `| \`${file.replace(/\\/g, '/')}\` | ${baseStats.has(file) ? formatBytes(base) : '—'} | ${headStats.has(file) ? formatBytes(head) : '—'} | ${diffFormatted} |`;
});

sections.push(
[
`**Output size:** ${changed.length} ${changed.length === 1 ? 'file' : 'files'} changed · net ${totalSign}${formatBytes(totalDiff)}`,
Expand Down
4 changes: 2 additions & 2 deletions scripts/comparators/object-assertion.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ export const details = (summary, diff) =>

const getFileDiff = async file => {
if (!baseFileSet.has(file)) {
return `- \`${file}\` added`;
return `- \`${file.replace(/\\/g, '/')}\` added`;
}

if (!headFileSet.has(file)) {
return `- \`${file}\` removed`;
return `- \`${file.replace(/\\/g, '/')}\` removed`;
}

const basePath = join(BASE, file);
Expand Down
Loading