jenkins: fetch refs before test commit rebase#4346
Open
trivikr wants to merge 1 commit into
Open
Conversation
Refresh the PR ref and rebase target before checking out the Jenkins local branch. When REBASE_ONTO exists locally without its parents, git can replay almost the entire Node.js history instead of only the PR commits. Fixes: nodejs#4345 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4345
Refresh the PR ref and
REBASE_ONTOinnode-test-commit-pre.shbeforechecking out
_jenkins_local_branchand runninggit rebase.When Jenkins has a shallow copy where
REBASE_ONTOexists locally withoutits parents,
git rebasecan treat nearly the entire Node.js history ascommits to replay. That caused failures like:
The script now fetches the refs it is about to use and unshallows the repository when needed.
Validation
bash -n jenkins/scripts/node-test-commit-pre.shgit diff --checkbefore=46899after=1Assisted-by: openai:gpt-5.5