Conversation
The float converter passes blank strings into Number(), which returns zero. Reject empty/whitespace-only strings while preserving surrounding whitespace on valid numeric input. Confidence: high Scope-risk: narrow Tested: Regression red/green, full test suite, exported API QA
Member
|
What is the reason for this PR? This is mainstreem port, deviations are not accepted, and your custom test will not be maintainable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The float converter passes blank strings into Number(), which returns zero. Reject empty/whitespace-only strings while preserving surrounding whitespace on valid numeric input.
The regression fails before the change and passes afterward. Coverage includes empty, space-only, tab/newline-only input plus valid padded numeric strings.
Validation: ESLint and the full 1,831-test suite pass using Node 22. Public API QA also passes Node 26.
AI assistance: OpenAI Codex was used to investigate, implement, and run the regression and full-suite checks.