Repository navigation
fix: report frames that fail to decode through handle_error/2 - #103
Merged
Merged
Conversation
`Mint.WebSocket.decode/2` returns a frame that fails to decode as `{:error, reason}` inside the frame list. That element reached `handle_frame/2` as if it were a frame, and `Minch.connect/3` receivers got it as `{:frame, ref, {:error, reason}}`.
It now goes to `handle_error/2` as `{:decode_frame, reason}`, the same shape as a payload that fails to decode as a whole. The other frames in the batch are still delivered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mint.WebSocket.decode/2returns a frame that fails to decode as{:error, reason}inside the frame list. That element reachedhandle_frame/2as if it were a frame, andMinch.connect/3receivers got it as{:frame, ref, {:error, reason}}.It now goes to
handle_error/2as{:decode_frame, reason}, the same shape as a payload that fails to decode as a whole. The other frames in the batch are still delivered.