Skip to content

fix: treat a replied close frame like a :close result #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbrone merged 3 commits into from
Sep 30, 2026
Merged

fix: treat a replied close frame like a :close result #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2222ad
fix: treat a replied close frame like a :close result
nmbrone Sep 30, 2026
21b0409
test: close a race in the send_frame/2 close handshake test
nmbrone Sep 30, 2026
4ab9590
Merge branch 'main' into fix/reply-close-parity
nmbrone Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/minch/conn.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ defmodule Minch.Conn do
end
end

defp send_reply({:close, _, _} = frame, state), do: state |> send_frame(frame) |> handle_close()
defp send_reply(:close = frame, state), do: state |> send_frame(frame) |> handle_close()
defp send_reply(frame, state), do: state |> send_frame(frame) |> handle_send()

defp handle_send({:ok, state}), do: {:noreply, state}
Expand Down
15 changes: 15 additions & 0 deletions test/minch/client_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,12 @@ defmodule Minch.ClientTest do

test "starts the close handshake for a :close frame sent with send_frame/2", ctx do
assert_receive {:client, :handle_connect, _}
# suspended so the server cannot answer, and end the handshake, mid-assertions
:sys.suspend(ctx.server)
assert :ok = Minch.send_frame(ctx.client, {:close, 1000, "bye"})
assert {:error, :closing} = Minch.send_frame(ctx.client, {:text, "hello"})
assert {:error, :closing} = Minch.send_frame(ctx.client, {:close, 1001, "again"})
:sys.resume(ctx.server)
assert_receive {:server, :terminate, {:remote, 1000, "bye"}}
assert_receive {:client, :handle_disconnect, [{:close, 1000, "bye"}, 1, _]}
end
Expand Down Expand Up @@ -261,6 +264,18 @@ defmodule Minch.ClientTest do
assert_receive {:client, :handle_disconnect, [{:close, 1000, ""}, 1, _state]}
end

@tag client_state: %{opts: [close_timeout: 200]}
test "a :close frame replied during the close handshake is ignored", ctx do
assert_receive {:client, :handle_connect, _}
# suspended so the server never answers our close frame
:sys.suspend(ctx.server)
assert :ok = Minch.send_frame(ctx.client, {:close, 1000, "bye"})
send(ctx.client, {:reply, {:close, 1001, "again"}})
refute_receive {:client, :handle_error, _}, 50
assert_receive {:client, :handle_disconnect, [{:close, 1000, "bye"}, 1, _state]}, 300
:sys.resume(ctx.server)
end

@tag client_state: %{opts: [close_timeout: 200]}
test "a :close result during the close handshake is ignored", ctx do
assert_receive {:client, :handle_connect, _}
Expand Down
Loading