Repository navigation
chore(deps): bump mint_web_socket from 1.0.4 to 1.0.6 - #100
Merged
Merged
Conversation
mint_web_socket 1.0.6 rewrote `Mint.WebSocket.Extension.accept_extensions/3` and lost the success typing of `Mint.WebSocket.new/4`, so dialyzer reports the `{:ok, conn, websocket}` branch in `handle_response/2` as unreachable. That is why dependabot's #87 failed CI; the code is correct and every test connects.
The bump is taken with `@dialyzer {:no_match, handle_response: 2}`, to be removed once upstream restores the typing.
Supersedes #87.
nmbrone
force-pushed
the
chore/mint-web-socket-1.0.6
branch
2 times, most recently
from
September 30, 2026 07:47
1f9d3cb to
9684968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mint_web_socket 1.0.6 rewrote
Mint.WebSocket.Extension.accept_extensions/3and lost the success typing ofMint.WebSocket.new/4, so dialyzer reports the{:ok, conn, websocket}branch inhandle_response/2as unreachable. That is why dependabot's #87 failed CI; the code is correct and every test connects.The bump is taken with
@dialyzer {:no_match, handle_response: 2}, to be removed once upstream restores the typing.Supersedes #87.