chore(deps): revert rand to 0.8 workspace-wide and pin it in dependabot config#10
Conversation
…ot config nitrite-bench, nitrite-spatial, and nitrite-vector were bumped to rand 0.9 in PR #8, while nitrite/Cargo.toml stayed pinned at 0.8.5 (rand 0.9's OsRng doesn't satisfy the rand_core 0.6 CryptoRng/CryptoRngCore traits that argon2's password-hash crate needs). Dependabot doesn't know about that constraint and keeps reopening the same broken bump (PR #9). Revert the three crates back to rand 0.8 so the whole workspace uses one rand major version, and add .github/dependabot.yml with an ignore rule so Dependabot stops proposing rand >=0.9. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughDependabot is configured for weekly Cargo updates while ignoring Changesrand version pinning
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 156 156
Lines 73638 73638
=======================================
+ Hits 69140 69141 +1
+ Misses 4498 4497 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
randinnitrite-bench,nitrite-spatial, andnitrite-vectorfrom 0.9 back to 0.8, so the whole workspace uses a single rand major version (matchingnitrite's existing=0.8.5pin)..github/dependabot.ymlwith anignorerule forrand >=0.9.0, since rand 0.9'sOsRngdoesn't satisfy therand_core0.6CryptoRng/CryptoRngCoretraits thatargon2'spassword-hashcrate needs. This is the same conflict that broke chore(deps): bump rand from 0.8.5 to 0.9.2 in the cargo group across 1 directory #8 and that dependabot re-proposed in chore(deps): bump rand from 0.8.5 to 0.9.2 in the cargo group across 1 directory #9 (dependabot has no way to know about this constraint on its own).Test plan
cargo build --workspace— clean, no errorscargo test --workspace— all passingSummary by CodeRabbit
randdependency to version 0.8 across benchmarking, spatial, and vector components.