Exempt pinLocation from i18n rule - #198
Merged
Merged
Conversation
jattasNI
approved these changes
Aug 6, 2026
jattasNI
enabled auto-merge (squash)
August 6, 2026 20:58
jattasNI
reviewed
Aug 6, 2026
jattasNI
force-pushed
the
pinLocation-i18n
branch
from
August 6, 2026 21:28
4737c1c to
1e3c9f3
Compare
Collaborator
|
The build isn't being retriggered by any of the pushes I've tried. I suspect it's due to this GitHub incident. I don't see any workarounds listed there so for now we just need to wait for this PR to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sl-table-column-mappingcomponent has apinLocationattribute that does not require translation, so should be included in the list of exemptions.