Skip to content

feat: add methylsieve module#12182

Merged
SPPearce merged 1 commit into
nf-core:masterfrom
nh13:nh/methylsieve
Jul 3, 2026
Merged

feat: add methylsieve module#12182
SPPearce merged 1 commit into
nf-core:masterfrom
nh13:nh/methylsieve

Conversation

@nh13

@nh13 nh13 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Adds a module for methylsieve, a fast, robust filter for unconverted reads in methylation sequencing (bisulfite / EM-seq). For each template it tallies monitored cytosines against the reference and tags (or filters) incompletely-converted reads, emitting the BAM plus a per-context / per-spike-in conversion-rate statistics TSV. It runs inline in the alignment pipe (aligner | methylsieve | samtools sort).

Tested against the sarscov2 paired-end alignment fixture + reference (with .fai) and a stub run.

PR checklist

  • This comment contains a description of changes (with reason).
  • Followed the module conventions in the contribution docs.
  • Added a resource label.
  • Used BioConda and BioContainers (bioconda::methylsieve=0.1.0; Seqera Wave community container).
  • nf-core modules test methylsieve --profile docker passes.
  • Broadcast software version numbers to topic: versions.

@nh13 nh13 added new module Adding a new module Ready for Review labels Jun 26, 2026
@nh13 nh13 force-pushed the nh/methylsieve branch from 7a9d510 to bb500bd Compare June 26, 2026 22:29

@atrigila atrigila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just these minor comments to be addressed. Thanks for your contribution :)

Comment thread modules/nf-core/methylsieve/tests/main.nf.test.snap
Comment thread modules/nf-core/methylsieve/meta.yml
@atrigila atrigila added awaiting-changes will be closed after 30 days and removed Ready for Review labels Jul 2, 2026
Add an nf-core module wrapping `methylsieve`, a fast filter for
unconverted reads in methylation (bisulfite/EM-seq) sequencing. It
tags (or filters) reads by per-template cytosine conversion against a
reference and emits the BAM plus a per-context conversion-rate stats
TSV. Runs inline in the alignment pipe (aligner -> methylsieve -> sort).

Tested against the sarscov2 paired-end alignment fixture + reference
with a stub run.
@nh13 nh13 force-pushed the nh/methylsieve branch from bb500bd to 98264ce Compare July 2, 2026 22:15
@atrigila atrigila added ready to merge and removed awaiting-changes will be closed after 30 days labels Jul 3, 2026
@SPPearce SPPearce added this pull request to the merge queue Jul 3, 2026
Merged via the queue into nf-core:master with commit d415851 Jul 3, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants