Skip to content

Modules : add kled#12159

Merged
tetedange13 merged 12 commits into
nf-core:masterfrom
tetedange13:modules-add-kled
Jul 3, 2026
Merged

Modules : add kled#12159
tetedange13 merged 12 commits into
nf-core:masterfrom
tetedange13:modules-add-kled

Conversation

@tetedange13

@tetedange13 tetedange13 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Add new nf-core module for kled

A caller of structural variants for long read data : https://github.com/CoREse/kled


PR checklist

Closes #12157

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker NO DOCKER AVAILABLE
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Comment thread modules/nf-core/kled/meta.yml Outdated
Comment thread modules/nf-core/kled/meta.yml Outdated
Comment thread modules/nf-core/kled/meta.yml Outdated
Comment thread modules/nf-core/kled/meta.yml Outdated
description: "An ultra-fast and sensitive structural variant detection tool for
long-read sequencing data."
homepage: "https://github.com/CoREse/kled/blob/v1.2.9H11/README.md"
documentation: "https://github.com/CoREse/kled/blob/v1.2.9H11/README.md"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
documentation: "https://github.com/CoREse/kled/blob/v1.2.9H11/README.md"
documentation: "https://github.com/CoREse/kled"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not point directly to the README for "documentation" ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is you point to a specific release, which others might forget to update when there is a version bump of the module.
Maybe better to point to it in the default branch: https://github.com/CoREse/kled/blob/master/README.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @mashehu's solution

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your answers, adressed by commit 7848e68 !

Comment thread modules/nf-core/kled/meta.yml Outdated
Comment thread modules/nf-core/kled/tests/main.nf.test.snap Outdated
@atrigila atrigila added awaiting-changes will be closed after 30 days and removed Ready for Review labels Jul 2, 2026
@tetedange13 tetedange13 added Ready for Review awaiting-changes will be closed after 30 days and removed awaiting-changes will be closed after 30 days labels Jul 3, 2026
felix.vandermeeren@chu-montpellier.fr and others added 2 commits July 3, 2026 16:47

@atrigila atrigila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments :)

@atrigila atrigila added ready to merge and removed Ready for Review awaiting-changes will be closed after 30 days labels Jul 3, 2026
@tetedange13 tetedange13 added this pull request to the merge queue Jul 3, 2026
Merged via the queue into nf-core:master with commit 24f94e6 Jul 3, 2026
23 checks passed
@tetedange13 tetedange13 deleted the modules-add-kled branch July 3, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: kled

3 participants