Skip to content

Remove tag based include filters - #17

Merged
nvnieuwk merged 1 commit into
mainfrom
remove/tag-filtering
Sep 30, 2026
Merged

nvnieuwk merged 1 commit into
mainfrom
remove/tag-filtering

Conversation

@nvnieuwk

Copy link
Copy Markdown
Member

This pull request removes tag-based include filters from the samplesheet logic, reflecting a shift to splitting samplesheets per tag. It also updates documentation to version 0.4.1 and adjusts the test snapshots to match the new logic. The most important changes are summarized below.

Samplesheet logic simplification:

  • Removed all tag-based conditions (e.g., checks for data.tag) from include_func in nfcmgg_preprocessing.yml, since samplesheets are now split per tag and these checks are redundant. [1] [2] [3] [4]

Documentation updates:

  • Updated the plugin version in README.md to 0.4.1 and added a changelog entry noting the removal of tag-based include filters. [1] [2]

Test updates:

  • Updated test snapshots in main.nf.test.snap to reflect the new samplesheet logic, ensuring tests align with the removal of tag-based filters. [1] [2]

@nvnieuwk
nvnieuwk merged commit 0de9396 into main Sep 30, 2026
5 checks passed
@nvnieuwk
nvnieuwk deleted the remove/tag-filtering branch September 30, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants