Repository navigation
Remove tag based include filters - #17
Merged
Merged
Conversation
matthdsm
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes tag-based include filters from the samplesheet logic, reflecting a shift to splitting samplesheets per tag. It also updates documentation to version 0.4.1 and adjusts the test snapshots to match the new logic. The most important changes are summarized below.
Samplesheet logic simplification:
data.tag) frominclude_funcinnfcmgg_preprocessing.yml, since samplesheets are now split per tag and these checks are redundant. [1] [2] [3] [4]Documentation updates:
README.mdto0.4.1and added a changelog entry noting the removal of tag-based include filters. [1] [2]Test updates:
main.nf.test.snapto reflect the new samplesheet logic, ensuring tests align with the removal of tag-based filters. [1] [2]