fix: add missing accessibility labels in header and storage quota#490
Merged
Merged
Conversation
AC1 - Header (Settings menu): - UserMenu.vue: replace invalid <div> wrapper with <template> inside <ul> - UserMenu.vue: add aria-label with "opens in new tab" hint on external links (Hilfe & FAQ, Kundencenter) so screen readers announce the context AC4 - Storage indicator: - StorageQuota.vue: add aria-label="Expand storage, opens in new tab" on the storage upgrade link to inform screen readers it opens a new tab - StorageQuota.vue: add aria-hidden="true" on NcIconSvgWrapper to prevent the decorative icon from being announced by screen readers Translations: - Add "opens in new tab" key to en, en_GB, de, de_DE l10n files - Add "Expand storage, opens in new tab" key to all four l10n files
memurats
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several interactive elements in the header and storage quota area were missing accessible labels, making them ambiguous or uninformative for screen reader users.
Changes:
src/components/UserMenu.vue
Replaced invalid "div" wrapper with "template" inside "ul" (a "div" directly inside "ul" is invalid HTML and can confuse screen readers)
Added aria-label on external links (Hilfe & FAQ, Kundencenter) that open in a new tab, appending ", opens in new tab" so screen readers announce the context
src/components/StorageQuota.vue
Added :aria-label="t('nmctheme', 'Expand storage, opens in new tab')" on the storage upgrade link to inform screen readers it opens a new tab
Added aria-hidden="true" on NcIconSvgWrapper to prevent the decorative cloud icon from being announced separately
l10n/en.json, l10n/en_GB.json, l10n/de.json, l10n/de_DE.json
Added standalone translation key "opens in new tab" (used by UserMenu for external links)
Added translation key "Expand storage, opens in new tab" (used by StorageQuota)
Not changed (already accessible):
Search, Settings menu, Notifications buttons — already have aria-label from Nextcloud core
App navigation menu — already fully labelled
Files list Add button and 3-dot action button — already have accessible names from Nextcloud core
Type and Modified filter buttons — already have visible text as accessible names