fix(playlists): hold a received playlist's owner to the actor that sent it - #2364
Merged
Merged
Conversation
karlitschek
force-pushed
the
fix/playlist-origin
branch
from
September 25, 2026 09:26
0956dc7 to
0325df2
Compare
…nt it A received Playlist is rebuilt into the collection of the actor named in its attributedTo, matched by owner and title. The only check before that was that the playlist's id is on the host that delivered it, which says nothing about whose playlist it is: the owner was taken from the document as given. The owner of a received playlist must now be the actor of the activity that carried it, or a channel on that actor's server whose own attributedTo names the actor (PeerTube sends playlists from the account and attributes them to the channel). A playlist naming a local owner, an owner not known here, or arriving without an activity is refused. Since the collection is looked up by that verified owner, an Update can only rebuild a collection received from the same remote actor. The check lives in PlaylistService::receive(), the one path that writes received playlists. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <frank.karlitschek@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <frank.karlitschek@nextcloud.com>
karlitschek
force-pushed
the
fix/playlist-origin
branch
from
September 25, 2026 09:42
0325df2 to
74e5789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(playlists): a received Playlist is stored under the actor of the activity that carried it — or a channel on that actor's server attributed to it, which is how PeerTube sends them — rather than under whatever owner the document names. Playlists that name a local owner, an unknown owner, or arrive without an activity are refused. The check is inPlaylistService::receive(), the one path that writes received playlists. Tests inPlaylistInterfaceTestandPlaylistServiceTest;docs/Architecture.mdupdated.chore(release): 0.26.65 with the rebuilt bundle, on master 0.26.63. Independent of fix: the 2026-09-25 review — backend, federation, queries, jobs, web client, operations #2363 (0.26.64); whichever merges second needs its version re-bumped.Checks run locally
phpunit (6655), vitest (3173), psalm, php-cs-fixer — green. Integration tests run in CI only.
AI disclosure
The code, tests and this index were produced with Claude Code (Claude Opus 5.5) and are awaiting the author's review.
Signed-off-byis added by the author.🤖 Generated with Claude Code