[stable35] feat(files_sharing): import the sharing dialog directly - #64164
Merged
Conversation
backportbot
Bot
requested review from
icewind1991,
kristian-zendato,
leftybournes,
provokateurin,
skjnldsv and
sorbaugh
and removed request for
a team
September 10, 2026 07:44
Member
|
/compile |
AndyScherzinger
approved these changes
Sep 10, 2026
susnux
approved these changes
Sep 10, 2026
The dialog is a Vue 3 component and this frontend is Vue 2, which is why it was reached through a bridge: a separate Vue 3 entry point registered it on `OCA.Sharing`, and the sidebar called through that global. @nextcloud/sharing 1.0.0-beta.3 declares Vue as a dependency rather than a peer, so npm installs its own copy next to it and the dialog runs on that one, the same way @nextcloud/dialogs already does. The sidebar imports the library directly and the bridge goes away: its entry point, the app symlink into the Vue 3 frontend, and the script and style that loaded it. That symlink was also what pulled this Vue 2 app through the Vue 3 lint and test configs, so the exclusions added for it are no longer needed. Signed-off-by: Barthelemy Briand <barthelemy.briand@nextcloud.com> Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
backport/64125/stable35
branch
from
September 10, 2026 08:17
a4de0aa to
41e17b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #64125