feat(share): add public share-review API under OCP\Share\ShareReview#61543
Open
AndyScherzinger wants to merge 6 commits into
Open
feat(share): add public share-review API under OCP\Share\ShareReview#61543AndyScherzinger wants to merge 6 commits into
AndyScherzinger wants to merge 6 commits into
Conversation
AndyScherzinger
requested review from
Altahrim and
ArtificialOwl
and removed request for
a team
Member
Author
|
/backport to stable34 |
CarlSchwan
reviewed
Jun 23, 2026
CarlSchwan
left a comment
CarlSchwan
left a comment
Member
There was a problem hiding this comment.
Need to run build/autoloaderchecker.sh
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
6 times, most recently
from
c4ea0a9 to
af59b39
Compare
AndyScherzinger
added
3. to review
This was referenced Jun 25, 2026
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
2 times, most recently
from
f306220 to
d45d8e1
Compare
Member
Author
|
@provokateurin @CarlSchwan worked on addressing your review comments. |
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
from
d45d8e1 to
e46b015
Compare
provokateurin
requested changes
Jul 6, 2026
provokateurin
left a comment
provokateurin
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the explanation to the event docs.
Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…re\ShareReview Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ssCheckEvent Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
from
e46b015 to
fa57f02
Compare
provokateurin
requested changes
Jul 8, 2026
Replace the time/timestamp string-int duo with a required lastModifiedTimestamp, turn expiration into an expiration timestamp, rename password to hasPassword and model the manage capability as a dedicated flag so the permissions field fits int-mask-of<Constants::PERMISSION_*>. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
from
82fdef7 to
4951d16
Compare
Member
Author
|
@provokateurin all open review comments from the last review should be addressed by 4951d16 - thanks for the review. I cleanup the DTO and also renamed the timestamp since technically speaking it is last-modified not creation time. As for the permissions, I changed it accordingly, yet had to add a "can manage" boolean to not loose the management bit which is not reflected in the permissions definition. |
provokateurin
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
OCP\Share\Events\ShareReviewAccessCheckEventas the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial.This is a discussed and agreed on measure to safeguard auditing-triggered share deletions throughout various apps using a "check back event mechanism", so apps can implement their support for this (any app that has shares basically, of any kind)
Docs at nextcloud/documentation#15223
Assisted-by: Claude Code:claude-sonnet-4-6
and
Assisted-by: Claude Code:claude-fable-5
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)