[stable34] fix(RemoteService): remove redundant stream cleanup in convertFileTo()#5780
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable34] fix(RemoteService): remove redundant stream cleanup in convertFileTo()#5780backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
The raw stream is handed to the Guzzle-based HTTP client as the request body; Guzzle wraps it in a PSR-7 stream and closes the underlying resource once the request has been sent. The fclose() call in the finally block therefore always operates on an invalid resource and logs a warning on every conversion (e.g. one per generated preview). Drop the try/finally block and rely on the HTTP client to close the stream, as suggested in review. Fixes #5743 Signed-off-by: Nicola Fabiano <nicola@nicfab.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #5755