Re-check result permission in submission export#3365
Merged
Conversation
pringelmann
added
enhancement
Collaborator
Author
|
/backport to stable5.2 |
Chartman123
approved these changes
May 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/export-results-permission
branch
from
e3eb311 to
0f7e893
Compare
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERMISSION_RESULTSshare-level check toexportSubmissionsToCloudgetFormIfAllowed(PERMISSION_RESULTS)uses the relaxedcanSeeResults()gate which also accepts submitters; the export endpoint needs the same strict recheckgetSubmissionsandgetSubmissionalready do (added in fix: do not add result permissions to see own submissions #3128)