Fix: add warning when public tag used for rule and only load tags once for all rules#437
Merged
Conversation
…e for all rules Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
julien-nc
approved these changes
Jul 21, 2026
julien-nc
left a comment
julien-nc
left a comment
Member
There was a problem hiding this comment.
Optional remarks.
Tested, works fine.
| return [ | ||
| 'id' => $tag->getId(), | ||
| 'displayName' => $tag->getName(), | ||
| 'canAssign' => $tag->getAccessLevel() === ISystemTag::ACCESS_LEVEL_PUBLIC, |
Member
There was a problem hiding this comment.
Shouldn't canAssign express if the current user can assign this tag? Currently is expressed if the tag is public. Might be fine, just curious.
Member
Author
There was a problem hiding this comment.
public tags are the only ones that can be assigned by any user. The wording isn't great though. I don't remember exactly why I chose that wording. It might have to do with the NcSelectTags component.
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.