disasm: fix truncation 32bit left bitwise shift - #285
Open
GermanAizek wants to merge 1 commit into
Open
Conversation
Even though shifting an 8-bit displacement usually won't exceed a 32-bit boundary, static analyzer flags it because a negative value (which has its sign bit extended into the 32-bit space) shifted left and then promoted to 64 bits can result in improper sign-extension or unintended data truncation at the 32-bit boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though shifting an 8-bit displacement usually won't exceed a 32-bit boundary, static analyzer flags it because a negative value (which has its sign bit extended into the 32-bit space) shifted left and then promoted to 64 bits can result in improper sign-extension or unintended data truncation at the 32-bit boundary