output/outelf.c: free the section name and struct on cleanup - #265
Open
succubus-uwu wants to merge 1 commit into
Open
output/outelf.c: free the section name and struct on cleanup#265succubus-uwu wants to merge 1 commit into
succubus-uwu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elf_cleanup() frees each section's data, relocations and reloc list,
then frees the
sectspointer array itself - but never the sectionstructs it points to, nor their strdup'd names. Every section leaks
on every ELF run. This is the ELF counterpart of the outobj.c
"free the section name on cleanup" fix.
Confirmed with
leaks(macOS): a multi-section elf64 assemble wentfrom "11 leaks for 864 total leaked bytes" to zero. Output is
byte-for-byte identical before and after across elf32/elf64/elfx32
including -F dwarf and -F stabs.
Sorry, I forgot the sign-off. Please add:
Signed-off-by: Anton Kochergin succubus.vwv@gmail.com