Skip to content

ci: track netresearch/.github reusables on @main again - #665

Merged
CybotTM merged 1 commit into
mainfrom
ci/unpin-org-reusable
Aug 3, 2026
Merged

ci: track netresearch/.github reusables on @main again#665
CybotTM merged 1 commit into
mainfrom
ci/unpin-org-reusable

Conversation

@CybotTM

@CybotTM CybotTM commented Aug 3, 2026

Copy link
Copy Markdown
Member

security.yml and auto-merge-deps.yml referenced netresearch/.github reusables by full SHA with a trailing # main comment — they were already meant to follow main and merely could not. They now do.

Why

Org-owned reusables are referenced by @main so an upstream fix reaches every consumer at once. SHA-pinning is for third-party actions; applied to netresearch/* it freezes the consumer and defeats the propagation model. Here it also left the repo inconsistent with itself: the sibling callers in docker-publish.yml, scorecard.yml and codeql.yml all track @main, so only the audit and auto-merge jobs sat on an old copy.

The githubactions:S7637 hotspot this leaves in SonarCloud is accepted house practice. If a quality gate blocks on it, mark the hotspot Safe rather than re-pinning.

Scope

A sweep over all 191 non-archived netresearch repos with a default branch found 1178 uses: netresearch/… references across 126 repos, of which 4 were pinned. Two of them are here; the others are being fixed in t3x-nr-llm and retro-skill.

Copilot AI review requested due to automatic review settings August 3, 2026 12:24
`security.yml` and `auto-merge-deps.yml` were SHA-pinned and carried a
trailing `# main` comment, while the sibling callers in
`docker-publish.yml`, `scorecard.yml` and `codeql.yml` already track
main. Org-owned reusables are referenced by `@main` so an upstream fix
reaches every consumer at once; SHA-pinning is for third-party actions.

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions reusable-workflow references to track the netresearch/.github org reusables on @main again (instead of a pinned full SHA), restoring the intended “central fix propagation” model and aligning with the repo’s other workflow callers.

Changes:

  • Switch security.yml reusable workflow call from a pinned SHA to @main.
  • Switch auto-merge-deps.yml reusable workflow call from a pinned SHA to @main.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/security.yml Updates the reusable node-audit workflow reference to @main.
.github/workflows/auto-merge-deps.yml Updates the reusable auto-merge-deps workflow reference to @main.

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@CybotTM
CybotTM merged commit a5917b7 into main Aug 3, 2026
20 checks passed
@CybotTM
CybotTM deleted the ci/unpin-org-reusable branch August 3, 2026 12:59
Epoche-Napoleon pushed a commit to Epoche-Napoleon/t3x-nr-llm that referenced this pull request Aug 4, 2026
)

`republish.yml` was the last caller in this repo still pinned to a tag
(`@v1.3.2`). It now tracks `@main` like every other
`netresearch/typo3-ci-workflows` reference here.

## Why

Org-owned reusables are referenced by `@main` so an upstream fix reaches
every consumer at once — that propagation is the whole point of keeping
them in one repo. A pin freezes this consumer on an old copy and
converts each upstream fix into a Renovate bump PR instead. That already
happened: the pin landed on 2026-04-24 and
[netresearch#154](netresearch#154) bumped it
`v1.3.1 → v1.3.2` the next day.

SHA- and tag-pinning is for **third-party** actions. It does not apply
to `netresearch/*`.

## How it got there

A Copilot review thread on
[netresearch#140](netresearch#140) asked for pin
immutability; it was applied in
[netresearch#153](netresearch#153)
([cdabfeb](netresearch@cdabfeb)),
which pinned both `release.yml` and `republish.yml`. `release.yml` lost
its pin again as a side effect of the template adoption in
[0f1114c](netresearch@0f1114cf) on
2026-06-16. `republish.yml` is not part of that template, so its pin
survived.

`.github/workflows/AGENTS.md` carried the "pin actions to a full SHA,
not mutable tags" rule with no org-owned carve-out next to it. This PR
adds that carve-out, outside the `AGENTS-GENERATED` blocks so the
generator does not drop it.

## Scope check

A sweep over all 191 non-archived `netresearch` repos with a default
branch found 1178 `uses: netresearch/…` references across 126 repos, of
which 4 were pinned. This is one of them; the other three are fixed in
[retro-skill#51](netresearch/retro-skill#51) and
[timetracker#665](netresearch/timetracker#665).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants