Support for new RealityScan's naming of culumns#3758
Open
le0o0oo wants to merge 3 commits intonerfstudio-project:mainfrom
Open
Support for new RealityScan's naming of culumns#3758le0o0oo wants to merge 3 commits intonerfstudio-project:mainfrom
le0o0oo wants to merge 3 commits intonerfstudio-project:mainfrom
Conversation
le0o0oo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent RealityScan updates renamed several columns in the CSV file (Internal/External camera parameters) to make them more explicit.
Affected columns:
ff_35mmpxpx_normpypy_normheadingyawThe rest remained unchanged. This is only a name change, so, behaviour-wise nothing changes.
This PR adds backward-compatible support for both the old and new column names