Fix doubled padding on recycled iOS labels - #32
Draft
farfromrefug with Copilot wants to merge 2 commits into
Draft
Fix doubled padding on recycled iOS labels#32farfromrefug with Copilot wants to merge 2 commits into
farfromrefug with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: farfromrefug <655344+farfromrefug@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix double padding on RecyclerViews due to ui-label settings
Fix doubled padding on recycled iOS labels
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recycled
NLabelinstances on iOS could render with accumulated padding because the native draw path applied insets more than once. This change keeps padding sourced fromtextContainerInsetonly, so reused cells preserve the expected spacing.Root cause
NLabel.drawText(in:)applied:textContainerInsetpaddingborderThicknesstextContainerInsetfrom effective padding and border widths, so the nativeUILabelpath could double-apply the same spacing on reused views.Change
NLabeldraw path to inset only bytextContainerInset.textRect(forBounds:)andintrinsicContentSize, which still account for padding as before.Effect
CollectionViewcells.UILabelrender path with the existing inset computation performed inindex.ios.ts.