Update to Zig 0.17.0#223
Open
AnErrupTion wants to merge 5 commits into
Open
Conversation
Signed-off-by: AnErrupTion <anerruption@disroot.org>
Signed-off-by: AnErrupTion <anerruption@disroot.org>
Signed-off-by: AnErrupTion <anerruption@disroot.org>
Signed-off-by: AnErrupTion <anerruption@disroot.org>
Signed-off-by: AnErrupTion <anerruption@disroot.org>
Contributor
Author
|
Well, I'm stupid. I did not see this comment at the beginning of the file: So now it does work, haha. However, it was quite slow due to the allocator, and using the SmpAllocator fixes that issue. |
Collaborator
|
It’s probably fine for the examples to be slow; they’re somewhere between tests and model code. |
Contributor
Author
Sure but, as a bonus, the SmpAllocator is guaranteed to be threadsafe, compared to whatever GPA Zig decided to initialise in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #220.
The multi-threading example needs to be fixed.