sec: fix nil Data panic in ValidateAtSignatureTime - #218
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
d266606 removed the nil Data branch from ValidateAtSignatureTime, so a nil Data now reaches ValidateSigTime which dereferences it (data.Signature()) and crashes the process with a nil pointer panic. A nil Data is the documented case where the certificate itself is being validated and the signature-time check is deferred until the certificate is used to validate another packet. Restore the deferral, and guard ValidateSigTime itself against nil Data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217
What
Datadeferral inValidateAtSignatureTime(removed by d266606): when the certificate itself is being validated, accept and let the check run when the certificate validates another packet.ValidateSigTimeagainst a nilData(returns false).Evidence
Before (on main):
After (this branch):
Full
go test ./...green, including the trust_config tests added in d266606.