fw: implement rib/announce management command - #206
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
Implements the rib/announce management command (closes named-data#195), which previously always returned 501. The PrefixAnnouncement Data packet carried in the command Interest's ApplicationParameters is parsed for its announced prefix (the name before the PA keyword component, optionally followed by version and segment components), its required ExpirationPeriod, and its optional route Cost. A route with origin prefixann (129) toward the face the command arrived on is inserted into the RIB and expires after the announced ExpirationPeriod, mirroring NFD's rib-manager. The control response carries the created route's parameters. PrefixAnnouncement signatures are not validated, as YaNFD has no trust schema configured for management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #195
rib/announcereturned 501 Not Implemented. This implements it:Name parsing and field handling were checked against NFD's rib-manager and the NDNts PrefixAnn builder for interop. Adds unit tests for the parser and the handler;
go build ./...andgo test ./fw/...pass.