Fix Docker build: bump base image to Go 1.25 - #204
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
go.mod requires Go 1.25.0 but the Dockerfile pins golang:1.24, so the image build fails at make with GOTOOLCHAIN=local. Also update the README build requirement (1.23 -> 1.25) to match go.mod. Fixes named-data#200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200
The Dockerfile pins
golang:1.24while go.mod requires Go 1.25, sodocker buildfails at themakestep. Bumps the base image togolang:1.25and updates the Go version noted in the README.Verified
makebuilds cleanly with a current toolchain (go1.26.6) and confirmed thegolang:1.25tag exists on Docker Hub.