Repository navigation
test: tighten namespace Resolve and Spell cases - #193
Merged
Merged
Conversation
Pin that a test file does not join a //declscope:namespace subject, only a core one. Drop the Spell case that repeated "named", and replace the case with an unreachable input (a stem-bearing path with an empty name) with one that shows the key uses the base name of a stemless file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 50 50
Lines 4214 4214
=======================================
Hits 4173 4173
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #192.
TestResolve: pin that a test file joins only a core subject. Under//declscope:namespace customonuser.go,user_test.gostaysuser.TestSpell: dropderived, which passed the same input shape asnamed. Replaceempty name with path(Resolved{}withhelper.go, whichResolvenever produces) witha/b/.go, which shows that the key uses the base name.Resolveresults withslices.Equal.mise x -- ./test_all.shpasses locally.🤖 Generated with Claude Code