Skip to content

git-reader: Add safety check for records JSON - #1560

Merged
leplatrem merged 1 commit into
mainfrom
git-reader-safety-check-files
Sep 21, 2026
Merged

leplatrem merged 1 commit into
mainfrom
git-reader-safety-check-files

Conversation

@leplatrem

@leplatrem leplatrem commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

If extraneous files are stored in the Git repo, this would prevent treating them as record.

If we had had such a safety check, we would have avoided the v42 crash on timestamp files introduced in #1557 (see RMST-517)

  File "/app/.venv/lib/python3.14/site-packages/anyio/_backends/_asyncio.py", line 2706, in run_sync_in_worker_thread
    return await future
  File "/app/.venv/lib/python3.14/site-packages/anyio/_backends/_asyncio.py", line 1100, in run
    result = context.run(func, *args)
  File "/app/app.py", line 800, in collection_changeset
    timestamp, metadata, changes = git.get_collection_changeset(
  File "/app/app.py", line 276, in wrapper
    return func(*args, **kwargs)
  File "/app/app.py", line 388, in get_collection_changeset
    record.get("last_modified", 0) for record in records_by_id.values()
AttributeError: 'int' object has no attribute 'get'

@leplatrem
leplatrem merged commit b3eccdf into main Sep 21, 2026
15 of 16 checks passed
@leplatrem
leplatrem deleted the git-reader-safety-check-files branch September 21, 2026 08:56

This branch was successfully deployed

1 active deployment
build — 2ef0eb75 Deployed Sep 18, 2026 by leplatrem via git_reader_container #2047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants