Question entry l10n fixes - #7790
Conversation
|
|
||
| a.question-entry--meta-item, | ||
| .question-entry--meta-item a { | ||
| color: inherit; |
There was a problem hiding this comment.
This changes ensures that the color rule below for .question-entry--meta-bold won't be used, due to specificity. Adding the following somewhere in this file will fix that:
a.question-entry--meta-bold {
color: var(--color-heading);
}| gap: p.$spacing-xs; | ||
| color: inherit; | ||
| text-decoration: none; | ||
| white-space: nowrap; |
There was a problem hiding this comment.
This means that all "meta" chips no longer wrap, which means that long product or topic titles, or long usernames won't wrap on narrow mobile views, forcing the user to horizontal scroll. On the other hand, it's nice to keep those chips together (unbroken), which I think is your intention. Just noting that.
| {% elif obj.channel == "direct_support" and obj.zd_updated_at and obj.zd_updated_at != obj.created %} | ||
| <span class="question-entry--meta-item"> | ||
| {{ _('Updated') }} | ||
| <time datetime="{{ obj.zd_updated_at.isoformat() }}"> |
There was a problem hiding this comment.
Do we want to lose the time element? These times will no longer be machine readable, or at least no longer more easily machine readable.
| b_open='<span class="question-entry--meta-bold">'|safe, b_close='</span>'|safe, | ||
| when=obj.last_answer.created|timesince, | ||
| a_open='<a href="'|safe + obj.last_answer.get_absolute_url() + '" rel="nofollow">'|safe, a_close='</a>'|safe %} | ||
| {{ b_open }}{{ name }}{{ b_close }} replied {{ a_open }}{{ when }}{{ a_close }} |
There was a problem hiding this comment.
Maybe add an L10N comment for this?
| </svg> | ||
| {% if user_is_contributor and not profile_username %} | ||
| {{ _('asked by') }} <a class="question-entry--meta-asked-by" | ||
| {{ _('asked by') }} <a class="question-entry--meta-bold" |
There was a problem hiding this comment.
Should this get the same treatment as replied below, so it's no longer a L10N fragment?
2 participants
Uh oh!
There was an error while loading. Please reload this page.