fix(herd): allow-set-title is tmux 3.5, and a tmux that rejects it gets a retry - #503
Merged
Merged
Conversation
…ts a retry CI on ubuntu-latest (tmux 3.4) answered `invalid option: allow-set-title` to every session start after #502, so no herd member could start there and the tmux-backed tests went red. The option arrived in 3.5, not 3.4. tmuxCanPinTitle now requires 3.5. And because a version string is a guess about a binary, startSession also learns the answer the hard way: when tmux rejects the pin it kills the half-made session (tmux stops at the command it rejects, after the session exists), remembers "no" for the rest of the process, and starts the member with the plan an older tmux understands. A wrong guess costs one retry, never a member. Verified: the full suite locally (tmux 3.6); the survival, tile and pinned- title suites in a node:22 container with the fake-runner fallback; and, as a baseline, main's own herd.mjs fails the same three tmux tests on Debian's 3.3a, so that older crash is pre-existing and separate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014HMV1QDcVY1xiaWWrZQM4S
ThreatCrush Security Scan0 finding(s) in the 2 file(s) this pull request changes. Nothing in the files this pull request changes. 93 pre-existing finding(s) elsewhere in the repository — **HIGH/CRITICAL**: 8 | **MEDIUM**: 75 | **LOW**: 10Not introduced by this pull request. The full set is in the Security tab.
…and 73 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After #502, every herd session start on ubuntu-latest failed with
invalid option: allow-set-title, and the three tmux-backed tests (survival, tile round trip, sidebar swap) went red on both CI jobs. The runner ships tmux 3.4; the option arrived in 3.5.tmuxCanPinTitlenow requires 3.5.startSessionalso learns the answer the hard way: if tmux rejects the pin, it kills the half-made session (tmux stops at the command it rejects, after the session exists), remembers "no" for the process, and retries with the plan an older tmux understands. A wrong version guess costs one retry, never a member.Verified
startSessionwith a fake tmux that claims 3.5 but rejects the option: twonew-sessionattempts, the second without the pin, the session removed in between, member started.herd.mjsfails the same three tests on Debian's tmux 3.3a (a separate, pre-existingpaneIndexcrash on that version), so 3.4 on the runner is the case this fixes.🤖 Generated with Claude Code
https://claude.ai/code/session_014HMV1QDcVY1xiaWWrZQM4S