fix(node/sync): fail fast if L2CrossDomainMessenger ABI fails to parse#1018
fix(node/sync): fail fast if L2CrossDomainMessenger ABI fails to parse#1018curryxbo wants to merge 1 commit into
Conversation
The package-level L2CrossDomainMessengerABI dropped the parse error with a blank identifier (, _). If the generated ABI ever failed to parse, the variable would be nil and only surface later as an obscure nil-dereference. Add an init() that panics at startup so the failure is caught at deploy time. No behavior change for the (normal) success path. Context: morph-l2/morph-ideas idea #3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
node/sync/deposit_log.goparses the L2CrossDomainMessenger ABI at package level but drops the error with a blank identifier:If the generated ABI ever failed to parse,
L2CrossDomainMessengerABIwould beniland only surface much later as an obscure nil-dereference at first use.Change
Add an
init()that re-checks andpanics at startup, so a broken ABI is caught at deploy time rather than deep in request handling. The normal (success) path is unchanged.Minimal, one file,
fmtalready imported.Context
Surfaced by morph-l2/morph-ideas idea #3 (silent error swallowing): https://github.com/morph-l2/morph-ideas/blob/main/idea-003.html
🤖 Generated with Claude Code