Skip to content

fix(node/sync): fail fast if L2CrossDomainMessenger ABI fails to parse#1018

Open
curryxbo wants to merge 1 commit into
mainfrom
fix/deposit-log-abi-fail-fast
Open

fix(node/sync): fail fast if L2CrossDomainMessenger ABI fails to parse#1018
curryxbo wants to merge 1 commit into
mainfrom
fix/deposit-log-abi-fail-fast

Conversation

@curryxbo

Copy link
Copy Markdown
Contributor

What

node/sync/deposit_log.go parses the L2CrossDomainMessenger ABI at package level but drops the error with a blank identifier:

L2CrossDomainMessengerABI, _ = bindings.L2CrossDomainMessengerMetaData.GetAbi()

If the generated ABI ever failed to parse, L2CrossDomainMessengerABI would be nil and only surface much later as an obscure nil-dereference at first use.

Change

Add an init() that re-checks and panics at startup, so a broken ABI is caught at deploy time rather than deep in request handling. The normal (success) path is unchanged.

Minimal, one file, fmt already imported.

Context

Surfaced by morph-l2/morph-ideas idea #3 (silent error swallowing): https://github.com/morph-l2/morph-ideas/blob/main/idea-003.html

🤖 Generated with Claude Code

The package-level L2CrossDomainMessengerABI dropped the parse error with a blank identifier (, _). If the generated ABI ever failed to parse, the variable would be nil and only surface later as an obscure nil-dereference. Add an init() that panics at startup so the failure is caught at deploy time. No behavior change for the (normal) success path.

Context: morph-l2/morph-ideas idea #3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@curryxbo curryxbo requested a review from a team as a code owner July 13, 2026 07:23
@curryxbo curryxbo requested review from twcctop and removed request for a team July 13, 2026 07:23
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@curryxbo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d2e4281-73d0-4415-a428-97abfc05256c

📥 Commits

Reviewing files that changed from the base of the PR and between 21d05b9 and db95c81.

📒 Files selected for processing (1)
  • node/sync/deposit_log.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deposit-log-abi-fail-fast

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant