docs(node-operation): single node type, verify-mode, drop deprecated zkTrie migration (#988)#148
Open
curryxbo wants to merge 5 commits into
Open
docs(node-operation): single node type, verify-mode, drop deprecated zkTrie migration (#988)#148curryxbo wants to merge 5 commits into
curryxbo wants to merge 5 commits into
Conversation
…h-l2/morph#988) - Remove the separate "validator node" page; there is one node type now. - Document DERIVATION_VERIFY_MODE on the node page: local (default, rebuild + compare versioned hashes vs L1) vs layer1 (pull beacon blob + derive via engine, equivalent to the former validator). Remind operators to set layer1 for the old validator-like L1-derivation behavior. - Drop the now-removed `make run-validator` commands from the docker upgrade guide. - Remove validator-node entry from the node-operators sidebar. Ref morph-l2/morph#966 (Feat: Sequencer Final PR) for the verify-mode behavior.
Deploying morph-doc with
|
| Latest commit: |
cb75308
|
| Status: | 🚫 Build failed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
pre-rail | cb75308 | Jul 15 2026, 06:18 AM |
📝 WalkthroughWalkthroughThis PR consolidates validator behavior into full-node configuration through ChangesValidator Node Consolidation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/build-on-morph/developer-resources/node-operation/full-node/1-run-in-docker.md`:
- Around line 199-203: The fenced log example in the docs is missing a language
tag which triggers markdownlint; update the fenced block around the log line
(`root hash or withdrawal hash is not equal originStateRootHash=0x...
deriveStateRootHash=0x...`) to include a language tag such as `text` (i.e.,
change ``` to ```text) so the markdown linter passes and the docs build cleanly.
- Around line 11-13: The callout's claim that there is "no longer a separate
'validator node' to run" should be softened and scoped to this specific guide to
avoid contradiction with other pages; update the text around the "Single node
type" callout to prefix it with a scope qualifier like "In this guide," or "For
this walkthrough," and avoid site‑wide absolutes, while keeping the existing
details about DERIVATION_VERIFY_MODE and the 'layer1' option and linking to
"Batch verification mode"; optionally add a short cross‑reference noting that
other docs (e.g., the integration one‑page) may still reference a separate
validator node and will be updated separately.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 84b991d1-81b3-459f-933f-09c39667bc69
📒 Files selected for processing (4)
docs/build-on-morph/developer-resources/node-operation/full-node/1-run-in-docker.mddocs/build-on-morph/developer-resources/node-operation/upgrade-node/2-upgrade-node-docker.mddocs/build-on-morph/developer-resources/node-operation/validator-node/1-run-in-docker.mdsidebars.js
💤 Files with no reviewable changes (3)
- docs/build-on-morph/developer-resources/node-operation/validator-node/1-run-in-docker.md
- docs/build-on-morph/developer-resources/node-operation/upgrade-node/2-upgrade-node-docker.md
- sidebars.js
Comment on lines
+11
to
+13
| :::info Single node type | ||
| There is no longer a separate "validator node" to run. Every node verifies the chain against L1; the verification method is selected by `DERIVATION_VERIFY_MODE`. If you want a node that derives blocks from L1 like the former validator, set it to `layer1` — see [Batch verification mode](#batch-verification-mode) below. | ||
| ::: |
There was a problem hiding this comment.
Keep the validator-node wording scoped to this guide.
This callout is fine here, but docs/build-on-morph/build-on-morph/1-integration-one-page.md still tells readers to run a “full node and validator node”, so the docs read as contradictory until that page is updated too. Either update that doc in the same PR or soften this note to avoid a site-wide claim.
♻️ Proposed fix
-There is no longer a separate "validator node" to run. Every node verifies the chain against L1; the verification method is selected by `DERIVATION_VERIFY_MODE`. If you want a node that derives blocks from L1 like the former validator, set it to `layer1` — see [Batch verification mode](`#batch-verification-mode`) below.
+There is no longer a separate "validator node" to run in this guide. Every node verifies the chain against L1; the verification method is selected by `DERIVATION_VERIFY_MODE`. If you want a node that derives blocks from L1 like the former validator, set it to `layer1` — see [Batch verification mode](`#batch-verification-mode`) below.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@docs/build-on-morph/developer-resources/node-operation/full-node/1-run-in-docker.md`
around lines 11 - 13, The callout's claim that there is "no longer a separate
'validator node' to run" should be softened and scoped to this specific guide to
avoid contradiction with other pages; update the text around the "Single node
type" callout to prefix it with a scope qualifier like "In this guide," or "For
this walkthrough," and avoid site‑wide absolutes, while keeping the existing
details about DERIVATION_VERIFY_MODE and the 'layer1' option and linking to
"Batch verification mode"; optionally add a short cross‑reference noting that
other docs (e.g., the integration one‑page) may still reference a separate
validator node and will be updated separately.
Comment on lines
+199
to
+203
| If a node detects a mismatch between the sequencer's submission and its own verification, it logs a line such as: | ||
|
|
||
| ``` | ||
| root hash or withdrawal hash is not equal originStateRootHash=0x... deriveStateRootHash=0x... | ||
| ``` |
There was a problem hiding this comment.
Add a language tag to the log example fence.
Markdownlint flags this fenced block as missing a language. Use text (or another appropriate language) so the docs build stays clean.
🧹 Proposed fix
-```
+```text
root hash or withdrawal hash is not equal originStateRootHash=0x... deriveStateRootHash=0x...</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>
[warning] 201-201: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
@docs/build-on-morph/developer-resources/node-operation/full-node/1-run-in-docker.md
around lines 199 - 203, The fenced log example in the docs is missing a language
tag which triggers markdownlint; update the fenced block around the log line
(root hash or withdrawal hash is not equal originStateRootHash=0x... deriveStateRootHash=0x...) to include a language tag such as text (i.e.,
change totext) so the markdown linter passes and the docs build cleanly.
</details>
<!-- fingerprinting:phantom:triton:quartz -->
<!-- cr-comment:v1:19a1f728dc4cf36e4152ad1b -->
_Source: Linters/SAST tools_
<!-- This is an auto-generated comment by CodeRabbit -->
Mainnet/Hoodi have been on MPT for a long time; the migration guide is no longer needed. Remove the page, its sidebar entry, and the inbound links from the full-node page (tip) and prune-state (caution).
curryxbo
changed the title
New Upgrade Node page for operators with an already-running node: in-place upgrade steps, env vars now required for all nodes, DERIVATION_VERIFY_MODE (local default / layer1 = former validator), and a caution to upgrade before the consensus switch height.
… is new Confirmed against morph node/derivation/config.go: BeaconRpc is the only required field (errors if empty); rollup/deposit/heights use per-network defaults. So upgrading the binary is enough; former validators just add DERIVATION_VERIFY_MODE=layer1.
…encer upgrade A validator is now the single node run in layer1 mode; the old run-morph-node validator commands still work unchanged. Only the separate validator container is gone. Keep the note concise rather than listing every command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/build-on-morph/developer-resources/node-operation/upgrade-node/0-centralized-sequencer-upgrade.md`:
- Around line 58-60: Update the fenced log block in the upgrade-node
documentation to use the text language identifier by changing its opening fence
to ```text, while leaving the logged content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5cd59d4e-395b-4e16-befa-6026ee8fdd3f
📒 Files selected for processing (2)
docs/build-on-morph/developer-resources/node-operation/upgrade-node/0-centralized-sequencer-upgrade.mdsidebars.js
🚧 Files skipped from review as they are similar to previous changes (1)
- sidebars.js
Comment on lines
+58
to
+60
| ``` | ||
| root hash or withdrawal hash is not equal originStateRootHash=0x... deriveStateRootHash=0x... | ||
| ``` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Specify a language for the fenced log block.
Add text after the opening fence to satisfy Markdown linting and improve rendering.
Proposed fix
-```
+```text
root hash or withdrawal hash is not equal originStateRootHash=0x... deriveStateRootHash=0x...
</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 58-58: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@docs/build-on-morph/developer-resources/node-operation/upgrade-node/0-centralized-sequencer-upgrade.md`
around lines 58 - 60, Update the fenced log block in the upgrade-node
documentation to use the text language identifier by changing its opening fence
to ```text, while leaving the logged content unchanged.
Source: Linters/SAST tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes morph-l2/morph#988
What
Update the node operation docs for the single-node model (issue morph-l2/morph#988; aligns with run-morph-node PR morph-l2/run-morph-node#100, verify-mode behavior from morph-l2/morph#966).
Changes
DERIVATION_VERIFY_MODE:local(default): rebuild blob from local L2 + compare versioned hashes vs L1.layer1: pull L1 beacon blob + derive via engine — equivalent to the former validator node. Reminder: setlayer1for that old validator-style L1-derivation behavior.make run-validator/make stop-validatorcommands.Scope
Limited to the node-operation module. No style rewrites; unrelated outdated content left untouched. Verified with a local
pnpm build(exit 0, no broken links underonBrokenLinks: 'throw').🤖 Generated with Claude Code
Summary by CodeRabbit
DERIVATION_VERIFY_MODE(including guidance to uselayer1for former validator behavior).localvslayer1options, and example mismatch output.