MONGOCRYPT-870 drop prefixPreview and suffixPreview#1184
Merged
Conversation
erwee
approved these changes
May 28, 2026
Member
|
I would have expected the python test that uses |
Member
Ah, I missed that you had update the python tests. |
Collaborator
Author
|
Drafting spec changes motivated an additional change: f1df06e drops "textPreview" entirely. "substringPreview" still signals the feature is experimental, and avoids continued use of the term "text". |
mdb-ad
approved these changes
May 29, 2026
blink1073
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies renames for query types and algorithms related to QE string features.
prefixPreviewandsuffixPreviewis now an error.suffixandprefixrequire use of thestringalgorithm (formerlytextPreview).Details
The
textPreviewalgorithm is still used forsubstringPreview. ButtextPreviewmay be dropped entirely if WRITING-37758 is approved. This is tracked in MONGOCRYPT-931.Choosing
string(rather thantext) was motivated by a request to rename public driver APIs from "text" to "string": DRIVERS-3531