Skip to content

MONGOCRYPT-870 drop prefixPreview and suffixPreview#1184

Merged
kevinAlbs merged 4 commits into
mongodb:masterfrom
kevinAlbs:D3408
May 29, 2026
Merged

MONGOCRYPT-870 drop prefixPreview and suffixPreview#1184
kevinAlbs merged 4 commits into
mongodb:masterfrom
kevinAlbs:D3408

Conversation

@kevinAlbs
Copy link
Copy Markdown
Collaborator

@kevinAlbs kevinAlbs commented May 28, 2026

Summary

This PR applies renames for query types and algorithms related to QE string features.

  • Setting the query type prefixPreview and suffixPreview is now an error.
  • suffix and prefix require use of the string algorithm (formerly textPreview).

Details

The textPreview algorithm is still used for substringPreview. But textPreview may be dropped entirely if WRITING-37758 is approved. This is tracked in MONGOCRYPT-931.

Choosing string (rather than text) was motivated by a request to rename public driver APIs from "text" to "string": DRIVERS-3531

@kevinAlbs kevinAlbs marked this pull request as ready for review May 28, 2026 15:37
@kevinAlbs kevinAlbs requested review from a team as code owners May 28, 2026 15:37
@kevinAlbs kevinAlbs requested review from blink1073, erwee, mdb-ad and sleepyStick and removed request for sleepyStick May 28, 2026 15:37
@blink1073
Copy link
Copy Markdown
Member

I would have expected the python test that uses suffixPreview to have failed. I need to double-check that we're using the as-build version of libmongocrypt in our Evergreen tests.

@blink1073
Copy link
Copy Markdown
Member

I would have expected the python test that uses suffixPreview to have failed. I need to double-check that we're using the as-build version of libmongocrypt in our Evergreen tests.

Ah, I missed that you had update the python tests.

Copy link
Copy Markdown
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinAlbs
Copy link
Copy Markdown
Collaborator Author

Drafting spec changes motivated an additional change: f1df06e drops "textPreview" entirely. "substringPreview" still signals the feature is experimental, and avoids continued use of the term "text".

@kevinAlbs kevinAlbs merged commit 0ea5b74 into mongodb:master May 29, 2026
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants