fix: intercom bubble positioning properly#6111
Merged
IMB11 merged 6 commits intoMay 20, 2026
Merged
Conversation
Member
IMB11
commented
May 16, 2026
IMB11
commented
- Last version of doing this was not the right way - intercom bubble management has been moved to root layout for both app and website rather than on root.vue server panel page & the app's App.vue
- Moved to a single composable which manages the entire intercom state
- Removed dependency on intercom's sdk
- Properly fixed collision issues with modals, action bars, sidebar etc.
Member
|
Note This changelog has been baked. Any further edits will not be reflected. Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixed
Security |
Member
Frontend previewsLast deployed commit is 1f1ccec4275d56fad2b756b4a12dfca7a7059c7d
|
tdgao
reviewed
May 20, 2026
tdgao
approved these changes
May 20, 2026
Contributor
tdgao
left a comment
tdgao
left a comment
There was a problem hiding this comment.
LGTM, just one small thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.