fix(session): invalidate token usage after pruning tool output - #999
Open
lewismosciski wants to merge 1 commit into
Open
lewismosciski wants to merge 1 commit into
lewismosciski wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Tool-output pruning retains later assistant usage measured over the original output. The next strategy therefore still sees the old token count and can call the summary model even when pruning brought the context below its limit.
Discard those stale usage fields from the pruned view. Keep measurements preceding the first pruned output, and preserve the original session records.
Validation: three regressions failed before the fix; 153 related tests passed afterward, with 20 skips. The assembler regression verifies that no summary call occurs and the corrected view survives reopening the session. Applicable changed-file pre-commit hooks passed. Full-repository pre-commit still reports existing lint/format failures on main, including
skills_manager.py:61andshell_validator.py:91.Related issue number
Found while inspecting the default context-compaction pipeline; no existing issue.
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check. (Both run; existing repository failures noted above.)