fix(cron): preserve pause when a running job finishes - #996
Open
lewismosciski wants to merge 1 commit into
Open
lewismosciski wants to merge 1 commit into
lewismosciski wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Pausing a running recurring job currently lasts only until that run finishes:
record_result()changes its status back toscheduled. Preservepausedwhile recording the result and advancing the next run. One-shot jobs and exhausted repeat limits still complete normally.Added regressions for successful/failed runs, terminal states, and a background run paused through a separate manager sharing the jobs file.
Validation:
python -m pytest tests/cron -q(103 passed); pre-commit passed for all three changed files. Full-repo pre-commit still reports existing failures on unchanged main, includingms_agent/config/skills_manager.py:61andms_agent/permission/shell_validator.py:91.Related issue number
None; found while tracing cron state transitions.
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check. Ran both; full-repo failures noted above.