fix(session): recover interrupted JSONL appends - #1000
Open
lewismosciski wants to merge 1 commit into
Open
lewismosciski wants to merge 1 commit into
lewismosciski wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Resuming a session whose last JSONL write was interrupted can lose the next message: appending joins it to the unfinished record, and the reader drops the combined line. A write interrupted inside a UTF-8 character also prevents the session from opening.
Separate an unterminated tail from the next append and skip records with invalid UTF-8 when reading. Keep the existing bytes and complete records intact, including a valid final record missing only its newline.
Validation: six regressions failed before the fix; 171 related tests passed afterward, with 20 skips. Tests cover partial JSON, partial UTF-8, a complete unterminated record, metadata-sidecar recovery, event readers, and sequence numbers. Applicable changed-file pre-commit hooks passed. Full-repository pre-commit reports existing main lint/format failures, including
skills_manager.py:61andshell_validator.py:91.Related issue number
Found while inspecting session-log recovery; no existing issue.
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check. (Both run; existing repository failures noted above.)