feat: add opt-in tool output validation#344
Draft
atesgoral wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_tool_call_results, disabled by default, to opt into server-side output schema validationstructuredContentagainstoutput_schemawhen the option is enabledstructuredContentas an internal tool error and skip validation for error responsesStacked on #343. This PR currently includes #343 because GitHub cannot base an upstream PR on a fork-only branch; after #343 merges, the diff should collapse to the output-validation commit.
Tests
dev test test TEST=test/mcp/configuration_test.rbdev test test TEST=test/mcp/server_test.rbdev test test TEST=test/mcp/tool/output_schema_test.rbdev test test TEST=test/mcp/client_test.rbdev testgit diff --checkNote
Minitest/AssertEmptyLiteraloffense attest/mcp/server_test.rb:713.