Skip to content

close zipFile before resolving promise #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesthomp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

close zipFile before resolving promise #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/src/main/java/com/rnziparchive/RNZipArchiveModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,7 @@ public void run() {
return;
}
}
zipFile.close();

@devin-ai-integration devin-ai-integration Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing resource leak: zipFile not closed on error paths

The new close() call correctly handles the success path, but zipFile is still not closed in two other paths: (1) when the catch block at line 427 handles an exception during file addition, and (2) when the early return at line 420-421 is triggered because a file doesn't exist. These are pre-existing issues not introduced by this PR, but for completeness the fix could use a try-with-resources or a finally block to ensure the zipFile is always closed. Similarly, unzipWithPassword at RNZipArchiveModule.java:77 and isPasswordProtected at RNZipArchiveModule.java:63 also don't close their ZipFile instances.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@jamesthomp jamesthomp Jun 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe its important the .close() call happens before the promise resolve, so a try-with-resources or a finally block would not fix the issue.

updateProgress(1, 1, destFile); // force 100%
promise.resolve(destFile);
} catch (Exception ex) {
Expand Down