feat: consolidate GregCore integration and release flow - #235
Open
mleem97 wants to merge 6 commits into
Open
Conversation
Integrate the reviewed security and performance changes, establish bounded runtime services, add contributor and maintainer documentation, and enforce the dev to pre-release to main promotion model.
Not up to standards ⛔
|
This was referenced Aug 13, 2026
Closed
Document the chronological branch audit, retained promotion branches, and rejected changes from redundant automation proposals.
Keep the legacy Rust FFI v7 table layout stable while making its Steam and P2P slots inert. Document the native Unity/Data Center/Steamworks boundary from the local reference assemblies.
Record the native multiplayer removal and the preceding branch/release integration commits in the Keep-a-Changelog ledger.
The native Data Center co-op boundary supersedes the former FishNet design guidance.
Record the obsolete agent-instruction cleanup in the commit ledger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open PR audit — 2026-08-13
The open pull requests were inspected oldest to newest. The audit found two
repeating proposal families, not 28 independent features:
CustomEmployeeManager.SetPortrait.The selected implementation validates logical IDs, rejects separators and
rooted paths, and canonicalizes the final path inside
ModAssets.FindObjectsOfType<Server>()calls withNetworkMapcollections. The selected implementation uses the authoritativeserver/broken-server registries and does not allocate a global scene scan in
the hot API path.
PR #207 is a broad architecture migration. It was reviewed separately and is
not merged wholesale because it changes the project layout and release model;
compatible ideas are documented in
docs/codebase/and the branch policy. Itmust not be mixed into the smaller security/performance integration without a
separate compatibility review.
refactor/il2cpp-version-neutralsentinel/fix-setportrait-traversal-*sentinel/path-traversal-setportrait-*sentinel/fix-setportrait-path-traversal-*perf/lua-server-module-*sentinel/fix-path-traversal-setportrait-*bolt/optimize-lua-server-lookup-*sentinel/fix-path-traversal-employee-manager-*sentinel/fix-setportrait-path-traversal-*bolt-optimize-findobjects-*sentinel-fix-path-traversal-*bolt/optimize-lua-server-module-*sentinel/fix-path-traversal-portrait-*bolt-optimize-server-lookups-*perf/optimize-findobjectsoftype-*sentinel/fix-custom-employee-manager-*sentinel/fix-path-traversal-setportrait-*bolt-optimize-lua-server-queries-*sentinel-security-pathtraversal-*bolt-optimize-luaserver-api-*sentinel/fix-path-traversal-portrait-*bolt/optimize-lua-server-api-*sentinel-fix-setportrait-traversal-*bolt-optimize-findobjectsoftype-*sentinel/fix-path-traversal-setportrait-*bolt-lua-server-opt-*sentinel/fix-path-traversal-setportrait-*bolt/optimize-lua-server-module-*Cleanup rule
After the integration PR is opened, each listed PR is closed with a link to
this audit. Its source branch is deleted only after GitHub confirms the PR is
closed and only when it is not
main,dev,pre-release, orrelease/*.The existing
release/v1.2.1branch is preserved as a historical snapshot.