Skip to content

Cover checkboxes of an array field mixed with disabled ones #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stof merged 1 commit into from
Sep 3, 2026
Merged

Cover checkboxes of an array field mixed with disabled ones #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions tests/Form/CheckboxTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,39 @@ public function testCheckboxMultiple(): void
$this->assertFalse($updateMail->isChecked());
$this->assertTrue($spamMail->isChecked());
}

public function testCheckboxMultipleWithDisabledCheckboxes(): void
{
$this->getSession()->visit($this->pathTo('/multicheckbox_disabled_form.html'));
$webAssert = $this->getAssertSession();

$disabledChecked = $webAssert->elementExists('css', '[name="mail_types[]"][value="update"]');
$disabled = $webAssert->elementExists('css', '[name="mail_types[]"][value="spam"]');
$newsletter = $webAssert->elementExists('css', '[name="mail_types[]"][value="newsletter"]');
$digest = $webAssert->elementExists('css', '[name="mail_types[]"][value="digest"]');

$this->assertTrue($disabledChecked->isChecked());
$this->assertFalse($disabled->isChecked());

// the enabled checkboxes come after the disabled ones, so a driver that
// numbers them differently than the browser does manipulates the wrong one
$this->assertFalse($newsletter->isChecked());
$this->assertFalse($digest->isChecked());

$newsletter->check();
$this->assertTrue($newsletter->isChecked());
$this->assertFalse($digest->isChecked());

$digest->check();
$this->assertTrue($newsletter->isChecked());
$this->assertTrue($digest->isChecked());

$newsletter->uncheck();
$this->assertFalse($newsletter->isChecked());
$this->assertTrue($digest->isChecked());

// the disabled ones were not affected
$this->assertTrue($disabledChecked->isChecked());
$this->assertFalse($disabled->isChecked());
}
}
19 changes: 19 additions & 0 deletions web-fixtures/multicheckbox_disabled_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html>
<head>
<title>Multicheckbox Disabled Test</title>
<meta http-equiv="Content-Type" content="text/html;charset=UTF-8"/>
</head>
<body>
<h1>Multicheckbox Disabled Test</h1>

<form method="POST" action="advanced_form_post.php">
<input type="checkbox" name="mail_types[]" checked="checked" value="update" disabled="disabled"/>
<input type="checkbox" name="mail_types[]" value="spam" disabled="disabled"/>
<input type="checkbox" name="mail_types[]" value="newsletter"/>
<input type="checkbox" name="mail_types[]" value="digest"/>

<input type="submit" name="submit" value="Register" />
</form>
</body>
</html>