Added support for querying arbitrary named tables #969
Merged
michelebastione merged 5 commits intoMay 31, 2026
Conversation
Split `OpenXml.Reader` into partial files: OpenXmlReader, OpenXmlReader.Mapped, OpenXmlReader.MergeCells and OpenXmlReader.Comments, and sealed the class to simplify the Dispose pattern. Unified `XmlReaderSettings` via `XmlReaderHelper.GetXmlReaderSettings` and refactored `OpenXmlStyles` to an async factory. Removed `OpenXmlConfiguration` from `GetSheetNames`/`GetSheetInformations` public signatures and add obsolete forwarding overloads for compatibility. Other minor modifications and cleanups.
…om arbitrary named tables
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for querying named tables in Excel worksheets through new QueryTable and QueryTableAsync methods in OpenXmlImporter, alongside refactoring OpenXmlReader into partial classes and optimizing XML reading and styles loading. The review feedback highlights several robustness issues in the new table querying and styles parsing logic. Specifically, it points out potential NullReferenceException and KeyNotFoundException risks, a bug where columns named identically to their Excel column letters could be deleted, a potential out-of-bounds index issue, and the need for case-insensitive sheet name matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
QueryTableandQueryTableAsyncAPI methods toOpenXmlImporterfor retrieving data from arbitrary tables in the worksheets.Resolves #341